SSENSE/vue-carousel

Feature Request: centralize detection of window features

Open

#333 opened on Nov 29, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
featuregood first issuehelp wanted

Description

Is your feature request related to a problem? I'm implementing a long Form with a carousel slides separate groups of inputs. I have an issue disabling the mouseDrag prop whenever the user focus on an imput and allowing it again onBlur.

It seems that this prop only configure the eventListeners on init, but doesn't change whenever the input does.

Describe the solution you'd like MouseDrag & TouchDrag to be able to change on the go.

If any, describe the alternatives you've considered I thought about disabling pointer-events: none; with css but then everything inside the form is useless.

Teachability, Documentation, Adoption, Migration Strategy Well, developers will be able to change the prop according to events other thant the initialization of the component.

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue.js basicsReactivity concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The user wants the mouseDrag and touchDrag props to be reactive. Investigate the main Vue component (likely in /src or similar) to see how these props are currently used. Implement watchers or computed properties to dynamically enable/disable event listeners based on prop changes. Refer to the issue #333 for details.