SSENSE/vue-carousel

Feature Request: Optionally tab through slides

Open

#315 opened on Nov 12, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
featuregood first issuehelp wanted

Description

Is your feature request related to a problem? Tabbing through the slides does not work correctly because a tabindex of -1 is added to each slide. I'm sure this was done for a good reason, but I'd be curious to hear why.

Describe the solution you'd like I would like to see an option added to the API Config to make that an optional feature. We need to be able to tab through the carousel slides for our site.

If any, describe the alternatives you've considered Alternatives would be manually editing the source code and hosting our own modified copy or switching to a different plugin.

Teachability, Documentation, Adoption, Migration Strategy Users can set an option like tabIndexNegOne to true or false in the initialization of the plugin.

Contributor guide

Tech stack
vuejavascript
Domain
frontendaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Vue.js knowledgeUnderstanding of tabindex attribute
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests adding an option to enable tabbing through slides. Look at the slide component (likely in src/components/Slide.vue) where tabindex is set to 1. Add a prop to the carousel config to control whether tabindex is overridden. Reference comments in the issue for any discussion about implementation details.