SSENSE/vue-carousel

Bug: wrong slide width on first init

Open

#233 opened on Jul 4, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (513 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (1,705 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Version: 0.9.0

Description

Slides has wrong width on first init.

It looks like reason of this is calculating slides width right after component init, when fonts are not loaded yet.

UPDATE: Here is my repository with demo page.

Screenshot

Screenshot

Steps to reproduce

  1. Open demo page.
  2. Look at last slide.
  3. Click on “×” button.
  4. Slides width fixed now.

After it all resources would be cached already and you need to clear cache with Ctrl + F5 to reproduce bug again.

Behavior

Expected

Slides fix its width only after all resources are loaded.

Observed

Slides fix its width right after initialization.

Contributor guide

Research direction
Inspect the carousel component's initialization lifecycle, specifically where slide widths are calculated. Consider using the document.fonts API or a fallback to recalculate widths after fonts are loaded.
Tech stack
vuejavascriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitVue.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60