SSENSE/vue-carousel

Bug: navigateTo="newSlide" doesn't work with 5 or more slides per page

Open

#193 opened on May 4, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
bughelp wantedneed repro

Description

If I change 5 slides per page for 4 or less, the :navigateTo prop works fine.

Here is my code, note that on 1024 width screen it does not work because of 5 slides.

<carousel
        ref="carousel"
        :per-page-custom="[[1024,5], [768,4], [480,4], [340, 3]]"
        :navigation-enabled="true"
        :pagination-enabled="false"
        :navigationClickTargetSize="0"
        :navigation-next-label="'<i></i>'"
        :navigation-prev-label="'<i></i>'"
        :navigateTo="newSlide"
        @pageChange="pageChange"
        :loop="true">
    <slide v-for="(p,k) in periods" :key="k">
        <a @click="period = p" :class="period == p ? 'active' : ''">{{ p.title
            }}</a>
    </slide>
</carousel>

Contributor guide

Tech stack
vuejavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Vue.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue occurs when per page custom includes 5 slides per page. Investigate the navigateTo functionality in the carousel component. Look at how the current page index is calculated when per page changes. Check the source code for potential off by one errors or incorrect handling of the active slide.