docs: Javalin sample README claims AMS authorization is an unimplemented TODO, but it is fully implemented

Open Beginner friendly
#98 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java
Domain
documentation

Research direction

Read ams-javalin-shopping/README.md at the authorization section and compare its claims with ams-javalin-shopping/src/main/java/com/sap/cloud/security/ams/samples/auth/AuthHandler.java. Update the README so it accurately reflects the implemented authorization, with no remaining claim that it is an unimplemented TODO.

Written by the indexing model from the issue text.

Description

ams-javalin-shopping/README.md currently claims authorization isn't implemented [1]. Instead of (as claimed) a stub, the authorization is implemented in AuthHandler.java [2].

[1] https://github.com/SAP-samples/ams-samples-java/blob/main/ams-javalin-shopping/README.md#L114-L123
[2] https://github.com/SAP-samples/ams-samples-java/blob/main/ams-javalin-shopping/src/main/java/com/sap/cloud/security/ams/samples/auth/AuthHandler.java

Dominant language
Java
Stars
0
Forks
0
Avg merge
2d 15h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SAP-samples/ams-samples-java

All issues in SAP-samples/ams-samples-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.