cpufeatures: use `is_*_feature_detected!` on targets with `std`?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- operating-systems
Research direction
Start by reading the cpufeatures target-detection implementation and the referenced is_*_feature_detected! macros. Compare the macro-based and CPUID approaches on OS targets, including the open x86 question. Done means the selected targets have an agreed detection strategy suitable for the next breaking release and new target features require less maintenance.
Written by the indexing model from the issue text.
Description
Sadly, the only popular target arch where a proper no_std target feature detection is available is x86(-64). For other targets we use OS-specific detection code.
Targets with OS generally have std, so we could use is_*_feature_detected! macros on them instead of re-implementing OS-specific target feature detection code. This would allow us to automatically support new target features with minimal maintenance burden.
I suggest we switch to the macros on selected targets with available std in the next breaking release.
One open question is whether we should use is_x86_feature_detected! on targets with OS or keep using our CPUID code.
- Dominant language
- Rust
- Stars
- 674
- Forks
- 170
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 10
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RustCrypto/utils
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
RustCrypto/utils#1546 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
RustCrypto/utils#1537 · 7 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
RustCrypto/utils#1529 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
RustCrypto/utils#1510 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
RustCrypto/utils#1509 ·
All issues in RustCrypto/utils
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
BurntSushi/jiff#653 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ZcashFoundation/zeeder#106 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oxidize-rb/rb-sys#807 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
todo:ticket
Difficulty 2/5 1-2 days Newbie friendliness 74/100