Roll20/roll20-character-sheets

[Dark Heresy 2nd Edition] Unnatural Characteristics not being added on successful tests

Open

#14138 opened on Jun 21, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (1,120 stars) (4,040 forks)batch import
help wanted

Description

If a character sheet has a value in the "Unnatural Characteristic" box (e.g., SC below has a Strength of 25 and Unnatural Strength (1)), half of the Unnatural Characteristic value, rounded up, should be added to Degrees of Success on a success, but only on a success, per rule SC below. Currently, the sheet does not add Unnatural Characteristic values on a successful test. Image

Image

Contributor guide

Tech stack
htmlcssjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic HTML/CSS/JavaScript knowledgeFamiliarity with Roll20 character sheet system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the Dark Heresy 2nd Edition character sheet template (likely in the 'sheets' folder) to locate the test result calculation logic. Look for functions handling degrees of success and check if there is any implementation for Unnatural Characteristics. The issue requires adding half of the Unnatural Characteristic value (rounded up) to successful tests. A good starting point is searching for 'unnatural' or 'characteristic' within the sheet's JavaScript file.