Roll20/roll20-character-sheets

[Swords & Wizardry] Ability prefills incorrect

Open

#13,461 opened on Oct 31, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (1,120 stars) (4,040 forks)batch import
good first issuehelp wanted

Description

When inputting ability scores for strength, the to-hit bonus prefills incorrectly as -1 instead of 0 for strength values of 9-12. There is also an error with an intelligence of 14 (spell level should be 7, languages should be 4, new spell should be 65%, min/max should be 5/8). The min/max spells prefill segment does not fit in the attributes box, and instead flows through the middle of the sheet. It is not visible unless a few extra saving throw bonus lines are added.

Contributor guide

Tech stack
htmlcssjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic HTML and CSSFamiliarity with Roll20 character sheet structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the Swords & Wizardry sheet file in the repository for ability score calculations and prefill logic. Check the JavaScript functions that compute to hit bonuses and intelligence based values. The layout issue suggests a CSS overflow or width problem in the attributes box; adjust the container's CSS to prevent content overflow.