these exact-match branches push the user without filtering against `usernames`

Open Beginner friendly
#40,961 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript
Domain
search

Research direction

Start in apps/meteor/server/lib/spotlight.js around lines 229-234 and compare the exact-match branches with the findByActiveUsersExcept paths below. Ensure exactMatch is evaluated against usernames so exact username results honor the exclusion list uniformly. Done means excluded usernames are not returned by either path.

Written by the indexing model from the issue text.

Description

todo type: bug

(the exclusion list), so an exact username query bypasses the exclusion that the
findByActiveUsersExcept paths below honor. Evaluate filtering exactMatch against
usernames here so the exclusion applies uniformly.

📝 Found in apps/meteor/server/lib/spotlight.js#L229

Commit: 9a36221f1fbf5ca417325204637c9f32fe760443

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
132

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat

All issues in RocketChat/Rocket.Chat

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.