chore(message-parser): remove orphaned i18next pluralization TODO from Reaction component

Open Beginner friendly
#39,925 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Open apps/meteor/client/components/message/content/reactions/Reaction.tsx and inspect the orphaned i18next pluralization TODO near line 15. Remove that stale comment; the task is done when the TODO no longer appears in the Reaction component.

Written by the indexing model from the issue text.

Description

type: feature

Current Behavior

In apps/meteor/client/components/message/content/reactions/Reaction.tsx, there is an outstanding technical debt marker at line 15:
// TODO: replace it with proper usage of i18next plurals

Tracing this component reveals that all manual pluralization has already been successfully migrated and abstracted away into the globally maintained @rocket.chat/fuselage component <MessageReactionCounter counter={counter} />. The TODO comment is now entirely orphaned dead code.

Expected Behavior

The stale // TODO comment should be deleted to prevent developer confusion and close out the tech debt marker, as the underlying architecture has already achieved the requested compliance.

Tasks

  • Delete // TODO: replace it with proper usage of i18next plurals from Reaction.tsx
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
132

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat

All issues in RocketChat/Rocket.Chat

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.