RocketChat/Rocket.Chat

Search not working on post attachments

Open

#2938 opened on Apr 18, 2016

View on GitHub
 (15 comments) (11 reactions) (0 assignees)TypeScript (45,311 stars) (13,573 forks)batch import
good first issuetriagedtype: improvement

Description

Your Rocket.Chat version: 0.26

Search seems to be working only on the text of the post and not on anything inside an attachment. This is quite a limitation when using integrations (e.g. - posting form gitlab on an alerting system. You want to use attachment to format the post in a readable way, using fields to better structure the data. But search does not work on the attachment so you can't search by the data in these fields).

Contributor guide

Tech stack
typescriptnodejs
Domain
searchbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of the Rocket.Chat codebaseFamiliarity with search functionality
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the search implementation in the codebase, focusing on how attachments are handled. The issue comments and file structure (likely in server/methods or models) should be explored. Look for the search logic and see if attachments are indexed. Check if there are any existing tests or related PRs that attempted to fix this.