Model default constructor does not initialize base Model structure members
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 48/100
Research direction
Start at the raylib::Model default constructor shown in the issue and inspect how it derives from ::Model. Reproduce the provided local-scope example under Visual Studio, then verify that destroying a default-constructed model no longer attempts to free invalid pointers.
Written by the indexing model from the issue text.
Description
I've found that raylib::Model class is deraived from ::Model structure.
Whe you instantiate raylib::Model with default constructor no any members of ::Model is initialized, under Visual Studio you got all of members filled with some debug non zero values.
When you try to call ~Model destructor you will try to free memory by invalid pointer.
This Code inserted anywhere in main will cause an error:
{
raylib::Model model;
// You'll get an exception on block exit
}
Very quick fix - add base structure initialization like this:
/**
* Model type
*/
class Model : public ::Model {
public:
Model() : ::Model{}
{
// Nothing.
}
- Dominant language
- C++
- Stars
- 960
- Forks
- 120
- Avg merge
- 10m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RobLoach/raylib-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
RobLoach/raylib-cpp#425 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
RobLoach/raylib-cpp#427 ·
-
Code gen Open
Difficulty 5/5 Over a week Newbie friendliness 30/100
RobLoach/raylib-cpp#415 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
RobLoach/raylib-cpp#370 · 1 comment ·
-
SDF Font Support Open
Difficulty 3/5 1-2 days Newbie friendliness 55/100
RobLoach/raylib-cpp#366 · 3 comments ·
All issues in RobLoach/raylib-cpp
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
duckdb/duckdb-wasm#2258 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objectionary/eo-graphs#75 ·
-
Coarray integration tests carry no LABELS, so run_tests.py silently skips them under every backend Opencoarray
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
FISCO-BCOS/FISCO-BCOS#5642 ·