RipMeApp/ripme

Implement subdirectory sanitisation

Open

#16 opened on Jul 9, 2017

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Java (640 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (3,524 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The addURLToDownload method in AbstractRipper should have sanitisation implemented for sub directories. It's currently possible to pass invalid characters and have the directory creation fail. This is particularly an issue on Windows platforms.

Another side effect of no sanitisation is that slashes in the directory name create further subdirectories.

Contributor guide

Research direction
Inspect the addURLToDownload method in AbstractRipper and implement sanitisation of subdirectory names to prevent invalid characters and unintended nesting.
Tech stack
java
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75