RicoSuter/NSwag

Bug - NSwag generates bad code for an enum

Open

#2,883 opened on Jun 9, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wantedproject: NJsonSchemaproject: NJsonSchema.CodeGeneration.CSharpproject: NJsonSchema.CodeGeneration.TypeScripttype: bug

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have 2 DTOs, both contain same Enum image

I have 2 controller methods using those DTO as URL query args image

I have 2 swagger definitions with same Enum image

And I get bad code from NSwag with "2" added to Enum name image

If this is not a bug then what am I doing wrong? Also this seem to be wrong only on method signature of the generated interface and the class, once I remove "2" the code compiles and I think it's generally ok code

image

Contributor guide

Research direction
Investigate why NSwag appends '2' to enum names when generating client code for duplicate enums in different DTOs. Trace the class generation logic in the NSwag codebase, focusing on how enums are named and how duplicates are handled.
Tech stack
csharptypescript
Domain
apibackenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70