RicoSuter/NSwag

POST response code check wrong

Open

#1,867 opened on Jan 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wanted

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi!

I tried the "TodoItem" from your "Get started with NSwag and ASP.NET Core". I used the swagger ui and tested POST api/todo and get a 201 response code. However when I use NSwag Studio it generates a C# client that checks that the code is 200 or 204. Have I missed something? Of course I can change the code but this must be a bug?

Best regards Peter

Contributor guide

Research direction
Investigate the NSwag C# client generation template for POST operations, specifically the expected response status codes. Compare with the OpenAPI specification generated by the sample ASP.NET Core project to see if the 201 status code is being correctly specified. Look for issues in the code generation logic that might override the response handling.
Tech stack
csharp
Domain
apitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#NSwag
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70