RicoSuter/NSwag

Angular typescript client generation support for DeepObject

Open

#1,665 opened on Oct 12, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (1,189 forks)batch import
help wantedproject: NSwag.CodeGeneration.TypeScripttype: bug

Repository metrics

Stars
 (6,291 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I think the section from /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid

{% elseif parameter.IsDeepObject -%}

must also be added to the typescript version in /src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestUrl.liquid for correct DeepObject suppor.

Contributor guide

Research direction
Examine the existing C# query parameter template for DeepObject support at /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid and replicate the logic in the TypeScript template at /src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestUrl.liquid, ensuring the generated TypeScript client correctly handles DeepObject parameters.
Tech stack
csharptypescript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#TypeScriptLiquid templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30