RicoSuter/NSwag

Route prefixing does not appear to work for dotnet core

Open

#1,386 opened on Jun 15, 2018

View on GitHub
 (10 comments) (0 reactions) (0 assignees)C# (6,291 stars) (1,189 forks)batch import
help wantedproject: NSwag.CodeGeneration.CSharp (Controllers)type: enhancement

Description

We are attempting to use SwaggerToCSharpControllerGenerator to generate a dotnet core compatible web api. Unfortunately we have a slight problem with route prefixing. The generator is generating the code [routeprefix('v1')] whereas, I believe that using dotnet core this needs to be [route('v1)]

Contributor guide

Tech stack
csharp
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsASP.NET Core routing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is about SwaggerToCSharpControllerGenerator generating incorrect route prefix syntax. Look at the generator code in the NSwag repository (likely NSwag.CodeGeneration.CSharp). Determine where route attributes are generated and why `[routeprefix('v1')]` is produced instead of `[route('v1')]`. Check if this is a version specific issue for .NET Core vs .NET Framework. There are 10 comments; review them for any additional context or proposed fixes.