RicoSuter/NJsonSchema

$ref: json is not validated to be a valid schema

Open

#594 opened on Jan 5, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (550 forks)github user discovery
help wantedtype: enhancement

Repository metrics

Stars
 (1,578 stars)
PR merge metrics
 (Avg merge 39d 6h) (1 merged PR in 30d)

Description

Hi,

No exception is thrown in case of referencing non-schema json. All other referenced schema-files were processed correctly

should be "Order": {"$ref": "Order.schema.json"}, was "Order": {"$ref": "Order.sample.json"}, expected Exception if it's not a schema

KR

Contributor guide

Research direction
Examine the code that resolves $ref references to see why non schema JSON files are accepted without validation; consider adding schema validation for referenced files.
Tech stack
csharp
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#JSON Schema
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60