RicoSuter/NJsonSchema

InvalidCastException on validation of JToken containing BigInteger

Open

#568 opened on Nov 25, 2017

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C# (550 forks)github user discovery
help wantedtype: bug

Repository metrics

Stars
 (1,578 stars)
PR merge metrics
 (Avg merge 39d 6h) (1 merged PR in 30d)

Description

Validation of JToken containing System.Numeric.BigInteger leads to InvalidCastException with message: "Object must implement IConvertible.". Exception is thrown on line 289 of JsonSchemaValidator(var value = token.Value();) in method "ValidateNumber".

That's a bug because instead of receiveng error you need to handle this exception in your code.

Contributor guide

Research direction
Investigate how to properly handle BigInteger conversion in the ValidateNumber method. Consider using Convert.ToDecimal or a try catch for IConvertible types.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NET
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65