Problem with Content negotiation - Status code

Open

#106 opened on Mar 11, 2014 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 48/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: php
Domain: api

Research direction

Reproduce the example in the issue with Accept: text/html and Accept: application/json. Read library/Respect/Rest/Routines/AbstractAccept.php around notifyDeclined and library/Respect/Rest/Router.php around informMethodNotAllowed to trace the status overwrite. Done means an unsupported representation returns HTTP 406 rather than HTTP 405.

Written by the indexing model from the issue text.

Description

bug

I'm using the latest Respect/Rest and probably I found a problem with content negotiation.

<?php

require __DIR__.'/vendor/autoload.php';

$r = new Respect\Rest\Router;
$contentNegotiation = [
   'text/html' => 'var_dump',
];
$r->get('/*/*', function(){
   return ['respect' => 'Ola!']; 
})->accept($contentNegotiation); 

$r->run();

If I send a request with header 'Accept: text/html' it works but if I send 'Accept: application/json', the application returns http 405 status code instead of 406.

I watch the source code, and at first the correct header is setted

protected function notifyDeclined($requested, $provided, Request $request, $params)
{
        $this->negotiated = false;
        header('HTTP/1.1 406');
}

Next, the status code is overwritten

protected function informMethodNotAllowed(array $allowedMethods)
    {
        header('HTTP/1.1 405');

        if (!$allowedMethods) {
            return;
        }

        $this->informAllowedMethods($allowedMethods);
        $this->request->route = null;
    }

I hope fix it and send a PR soon, meanwhile the @Respect team could help me too about how do it in better way :)

☁️

Dominant language: PHP
Stars: 605
Forks: 100
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

bench: run.sh's skip-update message always cites bench/skips.txt Open

tooling

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

svandragt/vivace#313 · Opened Sep 24, 2026
Monolingual text language selector is too internationalized Open

UX

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

ProfessionalWiki/NeoWiki#1525 · Opened Sep 24, 2026
Creating a plugin on a Windows PC with carriage returns in plugin comment block Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

givanz/Vvveb#526 · Opened Sep 24, 2026
checkRootlessDocker: in-script cron lock (420ca012) leaks its flock fd into the rootless daemons it starts — watchdog wedged after the first start tick (regression of #756) Open

bug customer-reported

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

MagnaCapax/PMSS#949 · Opened Sep 24, 2026
responsive-media kses allow-list strips clipPathUnits, collapsing objectBoundingBox clip paths Open

Difficulty 2/5 1-3 hours Newbie friendliness 84/100

Automattic/static-site-importer#1829 · Opened Sep 24, 2026

More PHP issues