Improve reliability of StopAvd with try-catch logic

Open

#64 opened on Feb 17, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: android, csharp
Domain: mobile-dev, tooling

Research direction

Start in AndroidSdk/Emulator/Emulator.cs and inspect the StopAvd polling loop, especially its calls to adb.GetDevices(). Review how SdkToolFailedExitException is handled elsewhere, then verify that shutdown failures do not escape the method and that StopAvd still returns a boolean by the timeout.

Written by the indexing model from the issue text.

Description

The 'StopAvd' method in 'AndroidSdk/Emulator/Emulator.cs' polls 'adb.GetDevices()' during shutdown, but 'GetDevices()' can throw 'SdkToolFailedExitException' if adb exits with a non-zero status.

As identified in PR #63 review (https://github.com/Redth/AndroidSdk.Tools/pull/63#discussion_r2818506593), this can cause 'StopAvd' to throw an exception instead of returning a boolean as expected.

To improve reliability, especially in CI environments where adb might be flaky during shutdown sequences, this method should:

Wrap the polling loop in a try-catch block.
Catch 'SdkToolFailedExitException' (and possibly others).
Treat failures as 'still running' (or retry) until the timeout is reached.

This ensures the method adheres to its contract of returning true/false rather than crashing.

Dominant language: C#
Stars: 78
Forks: 18
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[quality-improver] Repository Quality: AzureFoundry Extension Missing from Self-Registration Acceptance Test Open

type/automation type/tech-debt

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

microsoft/testfx#11431 · Opened Sep 21, 2026
[Bug]: Composite `ui screenshot` success output ignores `--quiet` Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

microsoft/winappCli#914 · Opened Sep 21, 2026
GeometryHelper.FlattenArc / FlattenCubicBezier / FlattenQuadraticBezier emit a NaN point when the segment count truncates to 0 (0/0) — a Path with a sub-pixel arc fail-fasts Windows with D2DERR_BAD_NUMBER (root cause of #8512, #13757) Open

t/bug

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

dotnet/maui#38751 · 1 reaction · Opened Sep 21, 2026
[CI Failure] Flaky: MauiBuildQueueTests.CancelQueuedResource_CompletesGracefullyAndDoesNotAcquireSemaphore asserts exact exception type but sometimes gets TaskCanceledException instead of OperationCanceledException Open

ci-failure-cause test-failure

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

microsoft/aspire#20284 · Opened Sep 21, 2026
The login flow's text-link submit is 42 px tall on a narrow screen; its docblock says 44 Open

area:auth FE mvp P3

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

klasolsson81/jobbliggaren#1788 · Opened Sep 21, 2026

More C# issues