ReceiptManager/receipt-parser-legacy

Fix failing unit test for market name

Open

#24 opened on Jun 2, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (762 stars) (192 forks)batch import
bughelp wanted

Description

In https://github.com/mre/receipt-parser/pull/23#issuecomment-497964607, @kiwita88 found the likely reason why our unit test for the market name 'p e n ny' fails. We should fix that.

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonunit testingreceipt parser codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the comment in PR #23 (https://github.com/mre/receipt parser/pull/23#issuecomment 497964607) to understand the root cause of the failing test for market name 'p e n ny'. Locate the unit test file and the parsing logic for market names. Adjust the parsing algorithm to correctly handle spaces in the market name.