RealOrangeOne/react-native-mock

Missing support for percentage widths

Open

#135 opened on May 24, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (151 forks)github user discovery
BugCompatabilityhelp wanted

Repository metrics

Stars
 (567 stars)
PR merge metrics
 (PR metrics pending)

Description

React Native has recently added support for percentage widths.

Tests now fail props validation if a react-native-mock component is passed a percentage width string instead of a number:

Error: Warning: Failed prop type: Invalid prop `style.width` of type `string` supplied to `View`, expected `number`.

Contributor guide

Research direction
Update the prop type validation for style.width to accept string values in addition to numbers.
Tech stack
javascriptreact
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React Native
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75