ReactiveX/rxjs

WebSocketSubject may have different input and output types.

Open

#5381 opened on Apr 6, 2020

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (31,024 stars) (3,007 forks)batch import
bughelp wanted

Description

Just what the title says... The AnonymousSubject (aka "frankensubject") probably also needs some typings love.

Basically, a nicer interface would be:

class WebSocketSubject<In, Out> extends Observable<Out> implements Observer<In> {
  // ...stuff
}

Contributor guide

Tech stack
javascripttypescript
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript genericsRxJS ObservablesWebSocketSubject
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue requests making WebSocketSubject generic over both input and output types. To implement, modify the WebSocketSubject class in src/internal/observable/dom/WebSocketSubject.ts to add separate type parameters In and Out, and update related typings. Also check AnonymousSubject for similar changes. There are no linked pull requests; this is an open issue with no assignees.