ReactiveX/rxjs

Rename window to windowWith

Open

#5296 opened on Feb 6, 2020

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (31,024 stars) (3,007 forks)batch import
help wanted

Description

We need to deprecate window, because it was a really dumb name, and rename it to windowWith or the like. I suggest windowWith just out of the spirit of concatWith and mergeWith renames... But I'm open to suggestions.

Related: https://github.com/ReactiveX/rxjs/issues/3788

Contributor guide

Tech stack
typescript
Domain
api
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptrxjs operators knowledgegit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is to rename the `window` operator to `windowWith` following the pattern of `concatWith` and `mergeWith`. There is a linked discussion in issue #3788. The assignee should review all usages of `window` in the source code, including tests and documentation. The new name needs to be agreed upon; the maintainer suggested `windowWith` but open to suggestions. After renaming, the old `window` should be deprecated and re exported for backward compatibility.