ReSwift/ReSwift

Behavior of skipRepeats unintuitive

Open

#352 opened on Jun 2, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (7,603 stars) (522 forks)batch import
Confirmed - Needs ImplementationGood First Issue

Description

If i explicitly define a skipRepeats function on my subscription selection I feel that it should take precedence over my type's == implementation. More than a few times I've been burned by not realizing the Subscription is forgoing skipRepeats because its selection is Equatable.

Contributor guide

Tech stack
swift
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReSwift subscriptionsSwift Equatable protocolskipRepeats usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current implementation of skipRepeats in Subscription.swift. Determine how the selection's Equatable concurrency is checked before applying the skipRepeats function. Review any related discussions in the issue comments (e.g., whether maintainers have indicated a preferred approach). Propose a change to prioritize the explicitly defined skipRepeats over the default Equatable check.