ReSwift/ReSwift

Behavior of skipRepeats unintuitive

Open

#352 opened on Jun 2, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (522 forks)batch import
Confirmed - Needs ImplementationGood First Issue

Repository metrics

Stars
 (7,603 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If i explicitly define a skipRepeats function on my subscription selection I feel that it should take precedence over my type's == implementation. More than a few times I've been burned by not realizing the Subscription is forgoing skipRepeats because its selection is Equatable.

Contributor guide

Research direction
Examine how skipRepeats is currently implemented in ReSwift's subscription mechanism and how it interacts with Equatable conformance. Look at the Subscription class and select function to understand the precedence. Consider adding a test that confirms custom skipRepeats should override Equatable.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftReSwift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55