Small inconsistency in the `lmBenchmark.R` file?
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- documentation
Research direction
Compare the method mapping in lmBenchmark.R with the documented RcppEigen::fastLm method values, starting from the shown exprs["LDLt"] entry and the fastLm documentation. Verify which value represents LDLT and update the inconsistent source or documentation; done when the benchmark and documentation agree.
Written by the indexing model from the issue text.
Description
In the lmBenchmark.R file I read
## LDLt Cholesky decomposition with rank detection
exprs["LDLt"] <- alist(RcppEigen::fastLmPure(mm, y, 2L))
but in the documentation for RcppEigen::fastLm the method is described as
an integer scalar with value [...] 3 for the LDLT Cholesky,
Is this correct?
> sessionInfo()
R version 4.2.0 (2022-04-22)
Platform: aarch64-apple-darwin20 (64-bit)
Running under: macOS 13.3.1
Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/lib/libRlapack.dylib
locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8
attached base packages:
[1] stats graphics grDevices utils datasets methods
[7] base
other attached packages:
[1] bench_1.1.3 RcppEigen_0.3.3.9.3 speedglm_0.3-5
[4] biglm_0.9-2.1 DBI_1.1.3 MASS_7.3-58.1
[7] Matrix_1.5-3
- Dominant language
- C++
- Stars
- 118
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from RcppCore/RcppEigen
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in RcppCore/RcppEigen
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 88/100
QuantStack/git2cpp#187 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100