RVC-Project/Retrieval-based-Voice-Conversion-WebUI

argparse help text weird

Open

#1,548 opened on Nov 15, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (2,849 forks)batch import
following upgood first issue

Repository metrics

Stars
 (18,427 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

infer/lib/train/utils.py 315 line, 318 line

    "-pg", "--pretrainG", type=str, default="", help="Pretrained Discriminator path"

    "-pd", "--pretrainD", type=str, default="", help="Pretrained Generator path"

I think these two should be swapped.

Contributor guide

Research direction
Verify the help texts for pg and pd in infer/lib/train/utils.py lines 315 and 318, then swap them if indeed incorrect.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90