e2e: placeholder dockerhub credentials trigger a real docker login and break builds

Open Beginner friendly
#192 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
docker, python
Domain
devops, testing-qa

Research direction

Start with tests/fixtures/dummy/credential.json and then inspect _usable_credentials() at src/madengine/core/auth.py:311. Run the affected e2e builds that report BUILD_FAILURE and verify that placeholder credentials no longer trigger a real Docker Hub login or cause the 16 tests to fail with exit 2.

Written by the indexing model from the issue text.

Description

tests/fixtures/dummy/credential.json ships placeholder dockerhub creds (your-docker-username). Non-blank, so _usable_credentials() (src/madengine/core/auth.py:311) accepts them and a real login runs:

unauthorized: incorrect username or password
... 429 Too Many Requests ... rocm/pytorch/manifests/latest
Base image pull was denied: rocm/pytorch

The build falls back to an anonymous pull, so behind a rate-limited IP 16 e2e tests fail with exit 2 (BUILD_FAILURE).

Dominant language
Python
Stars
9
Forks
18
Avg merge
5d 8h
Merged PRs (30d)
8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ROCm/madengine

All issues in ROCm/madengine

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.