BotManager can fail to call retire

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
backend

Research direction

Locate BotManager and trace the retire path, the bot loop, and its wait for game tick data. Verify the behavior when no tick arrives, and consider completion to mean that every bot's retire method has been called and all related threads have joined before retire returns.

Written by the indexing model from the issue text.

Description

bug

The BotManager can fail to call bots' retire method since the bot loop keeps waiting for a game tick data that never arrives.

I don't know if this happens in practice, but it looks possible from the code.

The BotManager should probably wait for all threads to join before returning from retire.

Dominant language
Java
Stars
1
Forks
1
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RLBot/java-interface

All issues in RLBot/java-interface

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.