Improve heuristic for opening docker-library/official-images PRs
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by tracing the current generated-manifest check that decides whether to open an official-images PR, then compare its behavior with docker-clojure PR #232. Review the proposed CI image builds and commit-message override approaches; done means agreeing on a reliable heuristic and defining how its decision is verified.
Written by the indexing model from the issue text.
Description
This pull request is a good example of why our current heuristic for whether or not we should automatically open a PR in docker-library/official-images is overly simplistic.
Currently we only open the official-images PR if the generated manifest file changes somewhere other than the git SHA.
However, PR #232 fixes a bug in the lein images but only bumps the git SHA in the manifest. It probably still makes sense to not always open an official-images PR on every change we merge here, though. But maybe just doing that is the simplest and most reliable option?
One option would be to build (some of*) the images in our CI pipeline here and detect when they change and base the decision on that. That would be tricky and slow, but is probably the most correct heuristic.
Another option would be to detect a string in the git commit message that forces an official-images PR (e.g. [force-official-images-pr]). We would just have to remember to add it when we needed it.
* It would likely be slow and unreliable to build every architecture in GitHub Actions' free tier infrastructure.
- Dominant language
- Dockerfile
- Stars
- 203
- Forks
- 34
- Avg merge
- 21m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Quantisan/docker-clojure
-
Temurin 27 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Quantisan/docker-clojure#296 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 64/100
Quantisan/docker-clojure#294 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
Quantisan/docker-clojure#224 · 6 comments ·
-
docs help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Quantisan/docker-clojure#131 · 2 comments ·
-
enhancement question
Difficulty 5/5 Over a week Newbie friendliness 20/100
Quantisan/docker-clojure#129 · 5 comments · 2 reactions ·
All issues in Quantisan/docker-clojure
Similar issues
-
kind/bug needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 72/100
matrixorigin/matrixone#29223 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
copse-dev/agent-pane#2953 ·
-
bug ci-failure high priority
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
vllm-project/vllm-omni#7972 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
bug good first issue
Difficulty 1/5 Under an hour Newbie friendliness 88/100
amponce/archive-movie-browser#166 ·