Qix-/color

lighten and darken should be absolute

Open

#53 opened on Feb 16, 2015

View on GitHub
 (18 comments) (13 reactions) (0 assignees)JavaScript (4,637 stars) (316 forks)batch import
bughelp wantedpr welcome

Description

Hey,

in LESS and SASS the darken nand lighten function increase by an absolute amount. Example here: https://github.com/less/less.js/blob/fb5280f16f124e5062634a22be2f3c99e650d0a4/lib/less/functions/color.js#L163

This is a bit confusing because in color.js e.g. `color('#000000').lighten(1)' is still black.

I am not sure though if it would be better to change the function or create a new one like lightenAbsolute.

Best, Finn

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptcolor theory basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current lighten and darken functions in the color library's source code (likely in `lib/color.js`). Review the issue comments (18 so far) for discussion on whether to modify existing functions or add new ones like `lightenAbsolute`. Consider the behavior of similar functions in LESS and SASS as referenced in the issue body (link to less.js line). Determine which approach the maintainers prefer and implement accordingly.