Qix-/better-exceptions

Command line not being read on Windows

Open

#27 opened on Mar 28, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (4,489 stars) (210 forks)batch import
enhancementhelp wanted

Description

On POSIX systems we can (ab)use ps to find the command line arguments that were used when calling the process.

However on windows, we're going to have to use ctypes and call CommandLineToArgvW.

There is a placeholder conditional for windows in there right now, but it currently doesn't do anything. This makes #17 only work on POSIX systems for now, and ideally it'd be great to be able to expand this functionality to Windows.

However, I don't currently have a windows box to test this on :)

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonctypesWindows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Find the placeholder for Windows command line parsing in the source code, likely in a conditional block. Implement the `CommandLineToArgvW` function using `ctypes` to retrieve command line arguments. Refer to the existing POSIX implementation that uses `ps` for guidance. Test the changes on a Windows machine.