PythonCharmers/python-future

Support @ in pasteurize (matrix multiplication)

Open

#472 opened on May 29, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (1,172 stars) (327 forks)batch import
futurize scripthelp wantedunscheduled

Description

If x @ y appears in a script, it should be changed to x.__matmul__(y). This is used mostly by Numpy.

If you'd like to get fancy about it, you can also support __rmatmul__ and __imatmul__, but just the first one is enough for now.

Contributor guide

Tech stack
python
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Python ASTFamiliarity with lib2to3
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining existing operator transformations in the pasteurize tool, e.g., look at the fixers in the 'python future' repository, such as 'libfuturize/fixes/fix add future imports.py' or similar files that handle binary operators. Understand how the @ operator is parsed in Python's AST and how to match it using lib2to3 patterns. The implementation should replace 'x @ y' with 'x. matmul (y)'. Check if there are any existing tests for operator transformations and ensure the new fixer follows the same convention. No linked PRs or maintainer comments are available; the issue is straightforward.