PythonCharmers/python-future

__bool__ = __nonzero__ not detected

Open

#453 opened on May 2, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (327 forks)batch import
0.19bugfuturize scripthelp wanted

Repository metrics

Stars
 (1,172 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Code like:

class Foo(object):
    def __nonzero__(self):
        return True
    __bool__ = __nonzero__

results in

from builtins import object
class Foo(object):
    def __bool__(self):
        return True
    __bool__ = __nonzero__

and therefore raises in Python3:

  File "test.py", line 2, in <module>
    class Foo(object):
  File "test.py", line 5, in Foo
    __bool__ = __nonzero__
NameError: name '__nonzero__' is not defined

Contributor guide

Research direction
Inspect the `python future` codebase, specifically the `libpasteurize` or `libfuturize` modules, and trace how ` nonzero ` is replaced by ` bool `. The bug occurs because the alias assignment ` bool = nonzero ` is not being recognized or updated correctly. Look for the handler that renames ` nonzero ` to ` bool ` and ensure it also updates any subsequent references like ` bool = nonzero `.
Tech stack
python
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50