PythonCharmers/python-future

futurize does not fix urllib.basejoin calls

Open

#383 opened on Oct 3, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (327 forks)batch import
0.19bughelp wanted

Repository metrics

Stars
 (1,172 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

futurize left my urllib.basejoin() calls in place, in stead of replacing them with urllib.parse.urljoin() calls.

Contributor guide

Research direction
Locate the futurize script's fixer for urllib and add a rule to replace basejoin with urljoin.
Tech stack
python
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65