PythonCharmers/python-future

futurize does not fix urllib.basejoin calls

Open

#383 opened on Oct 3, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,172 stars) (327 forks)batch import
0.19bughelp wanted

Description

futurize left my urllib.basejoin() calls in place, in stead of replacing them with urllib.parse.urljoin() calls.

Contributor guide

Tech stack
python
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python 2/3 urllib differences
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Check the libfuturize/fixes directory for existing urllib fixers. Add a new fixer that replaces urllib.basejoin with urllib.parse.urljoin. Review any existing PRs or comments for guidance. Test with a sample file containing basejoin calls.