PythonCharmers/python-future

future/builtins/misc.py doesn't use absolute import

Open

#313 opened on Nov 29, 2017

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (1,172 stars) (327 forks)batch import
0.19bughelp wanted

Description

This can cause a failure when there is a file called io.py in the same directory as a script.

Given two one line files: script_under_test.py : import builtins io.py : raise AssertionError("Don't import me")

python script_under_test.py

causes the following error:

  File "./bug_report/script_under_test.py", line 1, in <module>
    import builtins
  File "VE/lib/python2.7/site-packages/builtins/__init__.py", line 8, in <module>
    from future.builtins import *
  File "VE/lib/python2.7/site-packages/future/builtins/__init__.py", line 13, in <module>
    from future.builtins.misc import (ascii, chr, hex, input, isinstance, next,
  File "VE/lib/python2.7/site-packages/future/builtins/misc.py", line 43, in <module>
    from io import open
  File "/scr/dbw/hackNtest/bug_report/io.py", line 1, in <module>
    raise AssertionError("Don't import me")
  AssertionError: Don't import me```

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python 2/3 compatibilityunderstanding of import system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is in future/builtins/misc.py line 43 where 'from io import open' should be changed to an absolute import, e.g., 'from future.lib.io import open' (or similar based on the library's structure). The fix is straightforward and localized. No linked PR or recent comments indicate the assignee has not completed the work.