PythonCharmers/python-future

libfuturize.fixes.fix_absolute_import duplicates initial comments

Open

#281 opened on Apr 27, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (327 forks)batch import
0.19bughelp wanted

Repository metrics

Stars
 (1,172 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

precondition

  • Create thing/{__init__.py,foo.py,bar.py}
  • Fill foo.py with the following: 
    #!/usr/bin/env python
# -*- encoding: utf-8 -*-
import bar
  • run fix_absolute_import on thing

expected

foo.py should have become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
from . import bar

observed

foo.py has actually become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from . import bar

Contributor guide

Research direction
Examine the fix absolute import transformer code to understand how it processes comments and inserts new imports, then debug to prevent duplication.
Tech stack
python
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonAST
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65