PythonCharmers/python-future

Type not in (int, long) converted to not in (int, int)

Open

#265 opened on Jan 19, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (1,172 stars) (327 forks)batch import
0.19bughelp wantedtype-conversion

Description

Currently,

if type(time) not in (int, long): is converted to: if type(time) not in (int, int) (version 0.15.2)

This does not seem correct.

Following http://python3porting.com/differences.html I have instead changed this to:

if sys.version_info < (3,):
    integer_types = (int, long)
else:
    integer_types = (int,)

and then: if type(time) not in integer_types:

It would be excellent if this was built into futurize.

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonUnderstanding of Python 2/3 differences
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue describes a bug where futurize incorrectly converts 'not in (int, long)' to 'not in (int, int)'. Investigate the source code in the futurize script, likely in the type conversion logic. Look for where 'long' is replaced and ensure the correct mapping to integer types. The maintainer proposed an alternative using sys.version info, which could be a guide for the fix. The issue is old and uncommented, so verify the current state of the codebase.