PythonCharmers/python-future

Python 3.4 HTMLParser constructor has a convert_charrefs argument, which Python 3.5 warns about

Open

#163 opened on Aug 19, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,172 stars) (327 forks)batch import
0.19bughelp wanted

Description

The Python 3.4 convert_charrefs argument is missing from the Python 3.3 backport

https://github.com/PythonCharmers/python-future/blob/master/src/future/backports/html/parser.py#L122

Python 3.5 issues a warning if it is not used.

DeprecationWarning: The value of convert_charrefs will become True in 3.5. You are encouraged to set the value explicitly.

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python 3.xhtml.parser module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Check the current implementation in src/future/backports/html/parser.py around line 122. Add the convert charrefs keyword argument to the HTMLParser. init method, defaulting to False to maintain Python 3.3 compatibility, and ensure it is passed to the parent class. Verify that the deprecation warning from Python 3.5 is resolved.