PythonCharmers/python-future

futurize -a is not affected by fixer setting

Open

#114 opened on Oct 6, 2014

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Python (1,172 stars) (327 forks)batch import
0.22enhancementfuturize scripthelp wanted

Description

futurize -1 -w -n -a . will add print_function, division, and absolute_import (PS, can those be changed to be in alphabetical order?).

futurize -f libfuturize.fixes.fix_absolute_import -w -n -a . will add the above, plus unicode_literals and future imports.

It would be preferable if, when explicitly specifying a fixer, that only the __future__ imports relevant to that fixer were applied, in much the same way selecting stage 1 (-1) only uses imports that are "safe". This allows one to create smaller commits that would be easier to review and hopefully quicker to be applied.

Contributor guide

Tech stack
python
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python programmingUnderstanding of python future fixer system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `futurize` script in the python future repository. The issue is in the logic that applies ` future ` imports when a specific fixer is provided. Look at the main entry point (likely `libfuturize/main.py` or `futurize/ main .py`) to understand how fixers are selected and how imports are added. The goal is to ensure that only imports relevant to the specified fixer are added when ` f` is used.