KEMSystemMatrix: get_weighting_subset aliased to get_projection_subset
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 86/100
Research direction
Start in projectors/shared/kem_system_matrix.py:20 and compare the delegated methods with the SystemMatrix implementation. Trace the get_weighting_subset calls from PreconditionedGradientAscent in the prior, uncertainty, and BSREM paths, then reproduce the reported call. Done means those paths no longer raise a signature error and receive the weighting value expected by set_beta_scale and norm_BP_weight.
Written by the indexing model from the issue text.
Description
Hi, while reading through the KEM implementation I noticed KEMSystemMatrix sets
self.get_weighting_subset = self.system_matrix.get_projection_subset
in __init__ (projectors/shared/kem_system_matrix.py:20), but the two methods take different arguments:
get_projection_subset(projections, subset_idx)- two argumentsget_weighting_subset(subset_idx)- one argument
PreconditionedGradientAscent calls get_weighting_subset(subset_idx) with a single argument (in the prior, uncertainty, and BSREM paths), which would hit the two-argument get_projection_subset and raise TypeError. It also returns projections rather than the scalar weight that set_beta_scale / norm_BP_weight expect.
This looks like it would break any KEM reconstruction that uses a prior (or BSREM / uncertainty estimation). I think it should alias to self.system_matrix.get_weighting_subset. The signature mismatch reproduces locally. Let me know if I've misunderstood.
- Dominant language
- Python
- Stars
- 173
- Forks
- 38
- Avg merge
- 1h 17m
- Merged PRs (30d)
- 5
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PyTomography/PyTomography
-
SPECT data handling: rescale tags ignored when reading projections, plus a misleading docstringOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PyTomography/PyTomography#232 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
PyTomography/PyTomography#230 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 76/100
PyTomography/PyTomography#231 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PyTomography/PyTomography#227 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
PyTomography/PyTomography#229 ·
All issues in PyTomography/PyTomography
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
PedestrianDynamics/pyFDS-Evac#199 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
521xueweihan/HelloGitHub#3790 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sandialabs/atlas-ui-3#978 ·
Maintainers usually reply within 1 day
-
area: tests perceived difficulty: 2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Nitjsefnie-Harness-Commons/daedalus#1255 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
EleutherAI/lm-evaluation-harness#4256 ·
Maintainers usually reply within 1 day