ArrayRef instead of ArrayBase in function interfaces
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start with the implementations and documentation for PyArray::borrow_from_array and PyArray::from_array, then inspect the impl ToPyArray for ArrayRef and the ndarray dependency declaration. Check all affected call sites and existing project checks; done means the proposed interfaces and dependency requirement are updated consistently and the project still builds.
Written by the indexing model from the issue text.
Description
Hi,
I frequently find myself wanting a read-only array in Python backed by a Rust-owned buffer (usually to print it in an interactive session).
For this I use PyArray::borrow_from_array which takes a &ArrayBase as parameter.
I would like this function to take a &ArrayRef instead to be able to use it with a greater variety of arguments.
While this is a breaking change, I reckon the necessary code changes at call sites would be small, since ArrayBase already implements Deref<Target=ArrayRef>.
In my quick search I only found a couple of places, where this proposed change could be applied
PyArray::borrow_from_array,PyArray::from_array,impl ToPyArray for ArrayRef(? not sure about this one).
Another consequence would be to bump the minimum version of the ndarray dependency to 0.17.1.
Kind regards!
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 141
- Avg merge
- 16m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PyO3/rust-numpy
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
PyO3/rust-numpy#565 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 56/100
PyO3/rust-numpy#557 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
PyO3/rust-numpy#547 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 20/100
PyO3/rust-numpy#535 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
PyO3/rust-numpy#527 · 1 comment ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100