PyO3/pyo3

Seal traits inside `impl_` submodule

Open

#3,908 opened on Feb 27, 2024

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Rust (668 forks)batch import
Good First Issue

Repository metrics

Stars
 (10,152 stars)
PR merge metrics
 (Avg merge 9d 18h) (51 merged PRs in 30d)

Description

Off the back of https://github.com/PyO3/pyo3/pull/3897#discussion_r1504721475

Should we review the traits inside the impl_ submodule, check which ones can be sealed, and do that? It's a reasonable safety mechanism to prevent users from trying to implement those things.

Contributor guide

Research direction
Review the traits inside the `impl ` submodule to determine which ones can be sealed, then implement sealing using the standard Rust pattern (e.g., a private supertrait) to prevent external implementation.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rusttraits
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60