Ptt-official-app/pttbbs-backend

types.Big5ToUtf8 or pttbbstypes.Big5ToUtf8

Open

#161 opened on Mar 17, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (17 forks)github user discovery
Reviewgood first issuehelp wanted

Repository metrics

Stars
 (34 stars)
PR merge metrics
 (Avg merge 21d 14h) (3 merged PRs in 30d)

Description

Provide the github link(s) of the file#line (請提供 github 關於 code 的 link)

https://github.com/Ptt-official-app/go-openbbsmiddleware/blob/main/types/rune.go#L164 https://github.com/Ptt-official-app/go-pttbbs/blob/main/types/big5.go

What would you like to discuss (你想要討論什麼呢？～)

目前 go-openbbsmiddleware 是使用 types.Big5ToUtf8.

但是 go-pttbbs 後來也有相對應的 types.Big5ToUtf8. 因為 go-pttbbs 需要把 config 裡的 BBSNAME (utf8) 轉成 BBSNAME_BIG5 (big5). 用在 create-article 時的站名.

to discuss:

  1. 持續沿用 types.Big5ToUtf8, 因為 go-pttbbs 的是特例.
  2. 使用 pttbbstypes.Big5ToUtf8, 不需要重複寫一樣的 code.

Contributor guide

Research direction
Compare the two Big5ToUtf8 implementations in go openbbsmiddleware and go pttbbs. Decide whether to reuse the pttbbstypes version or keep the local copy based on dependencies and maintainability.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85