Use chunked upload for large files

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, php
Domain
backend

Research direction

Start by tracing the ApiUpload path and the existing check for MediaWiki's $wgMaxUploadSize, then compare it with PHP's post_max_size and upload_max_filesize behavior in php.ini. Done should mean files exceeding those PHP limits are handled with a clear upload error rather than failing silently; the issue also calls for chunked upload support for large files.

Written by the indexing model from the issue text.

Description

enhancement help wanted

If a file exeeds post_max_size or upload_max_filesize set in php.ini the upload will fail without proper error message.

It seems that PHP does not raise an error when the file is too large and ApiUpload is not explicitly testing this error condition, so no error message is generated.
MediaWiki's own $wgMaxUploadSize is checked however.

Workaround for the moment: Raise the php.ini settings above the largest expected file size.

Dominant language
JavaScript
Stars
22
Forks
17
Avg merge
5h 30m
Merged PRs (30d)
13

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ProfessionalWiki/SimpleBatchUpload

All issues in ProfessionalWiki/SimpleBatchUpload

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.