PrismJS/prism

Keep Markup and zero-length tags

Open

#1640 opened on Nov 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (11,488 stars) (1,296 forks)batch import
bughelp wantedplugins

Description

The current implementation of the Keep Markup plugin does not handle zero-length tags (tags with textContent.length == 0) correctly.

It will move any nested zero-length tag at the end of its parent outside and after its parent, effectively flattening the markup structure. Examples:

  • <x><y></y></x> -> <x></x><y></y>
  • <x>a<y></y></x> -> <x>a</x><y></y>
  • <x>a<y></y><z></z></x> -> <x>a</x><y></y><z></z>
  • <x>a<y><z></z></y></x> -> <x>a</x><y></y><z></z>

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with PrismJSJavaScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Keep Markup plugin in the PrismJS repository (likely in plugins/keep markup/). Look at the code that traverses the DOM and handles zero length tags. The issue describes the expected behavior: zero length tags should remain nested. To fix, identify where the plugin incorrectly detaches empty tags and adjust the logic to preserve their position. Consider adding test cases for the examples provided.