PrismJS/prism

Keep Markup and zero-length tags

Open

#1,640 opened on Nov 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,296 forks)batch import
bughelp wantedplugins

Repository metrics

Stars
 (11,488 stars)
PR merge metrics
 (Avg merge 86d 15h) (12 merged PRs in 30d)

Description

The current implementation of the Keep Markup plugin does not handle zero-length tags (tags with textContent.length == 0) correctly.

It will move any nested zero-length tag at the end of its parent outside and after its parent, effectively flattening the markup structure. Examples:

  • <x><y></y></x> -> <x></x><y></y>
  • <x>a<y></y></x> -> <x>a</x><y></y>
  • <x>a<y></y><z></z></x> -> <x>a</x><y></y><z></z>
  • <x>a<y><z></z></y></x> -> <x>a</x><y></y><z></z>

Contributor guide

Research direction
Examine the Keep Markup plugin source code to understand how it processes tags. Focus on the logic that moves nested tags and find where zero length tags are mishandled. Write a test to reproduce the issue and then implement a fix.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60