PrismJS/prism

Keep Markup: the markup is removed if it's the last element

Open

#1,618 opened on Nov 18, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,296 forks)batch import
bughelp wantedplugins

Repository metrics

Stars
 (11,488 stars)
PR merge metrics
 (Avg merge 86d 15h) (12 merged PRs in 30d)

Description

I don't if this is intended or not but if the markup (in the exemple below <div class="keep"></div>") is the last element, the Keep Markup plugin will remove it:

<!DOCTYPE html>
<html>
  <head>
    <link href="prism.css" rel="stylesheet" />
    <style>
    .keep {
      height: 1rem;
      width: 1rem;
      background-color: red;
    }
    </style>
  </head>
  <body>
    <pre><code class="language-css"><div class="keep"></div>p { color: red }<div class="keep"></div></code></pre>
    <script src="prism.js"></script>
  </body>
</html>

And here's the result:

error

As you can see the first <div class="keep"></div> is preserved but the last is removed. If I add some content after the div then it's working as expected:

good

Contributor guide

Research direction
Inspect the Keep Markup plugin code in Prism to understand how it handles markup elements that are the last child in the code block. Look for logic that may remove trailing elements incorrectly.
Tech stack
javascriptcsshtml
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptDOM manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50