Separate multi store email logo does not get picked up

Open Beginner friendly
#32,142 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
php
Domain
backend

Research direction

Review the linked upstream commit and the Configuration::get path, focusing on how PS_LOGO_MAIL is resolved when an email uses a specific id_shop. Reproduce the issue in a multistore setup with different logos and send emails for each shop. Done means the shop-specific email logo is selected on the 8.0 branch as it is in develop.

Written by the indexing model from the issue text.

Description

8.2.x BO Email theme Improvement Multistore Ready
Prerequisites
Describe the bug and add attachments

Bug in PrestaShop 8.0 which is already fixed in develop. Fix:
https://github.com/PrestaShop/PrestaShop/commit/429189083e0f4dc872b2b1a8952af99eec4c96f9

From the commit message:

When emails are sent with a specific $id_shop in parameter, if a different PS_LOGO_MAIL is configured for this shop it won't be used because Configuration::get uses the contextualised shop to check if a specific LOGO_EMAIL exists

Can this be fixed in PS 8.0 also please?
Shouldn't PS 8.0 get all relevant upstream bug fixes automatically?

Expected behavior

No response

Steps to reproduce

Setup multi store environment with different logos and send mails

PrestaShop version(s) where the bug happened

8.0

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

headissue GmbH

Dominant language
PHP
Stars
9.2k
Forks
5k
Avg merge
2d 13h
Merged PRs (30d)
50

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PrestaShop/PrestaShop

All issues in PrestaShop/PrestaShop

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.