[Formatter] Do not force indentation style unless certain line length were met

Open
#2,148 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
50/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp, powershell
Domain
tooling

Research direction

Reproduce the formatter behavior with the PowerShell example in the issue, then locate the formatter implementation and its existing tests. Determine how the line-length condition should affect indentation enforcement; done means short statements retain the compact form shown under “expected” without breaking the formatter’s existing behavior.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Up for Grabs
Prerequisites
  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been requested.
Summary

Formatter always format code as the specified indent style no matter how long the statement is:

# before
$foo = if ($true) {1} else {0}

# after 
$foo = if ($true) {
    1
} else {
    0
}

# expected
$foo = if ($true) { 1 } else { 0 }

The code became too sparse by being enforced to the indentation style.

Proposed Design

No response

Dominant language
C#
Stars
2.2k
Forks
415
Avg merge
13h 1m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSScriptAnalyzer

All issues in PowerShell/PSScriptAnalyzer

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.